Run tests against PHP 7.2, too #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If multiple e2e tests are run without process isolation there would be repeated real session starts - this was problematic but silent before, PHP 7.2 added an error to indicated it (https://bugs.php.net/bug.php?id=75227). https://stackoverflow.com/a/29563414 does a good job explaining the options used in silex' SessionServiceProvider.
gbirke
approved these changes
Feb 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1193
Depends on
Please verify that 86cfc84 does make sense for you, too. I think it silently did what it could before, now rightfully got a voice after all - should have been outside the if all along [1].
Maybe worth pointing out that this is not to say that the application is now entirely 7.2-ready. There was no UAT.
[1] https://silex.symfony.com/doc/2.0/testing.html#webtestcase