Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change options order index #1407

Merged
merged 1 commit into from
Dec 12, 2018
Merged

Change options order index #1407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/config/campaigns.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,12 @@ membership_call_to_action:
active: true

amount_options:
description: Test different amount options
description: Test different amount options. First two options are the same because we want to avoid having 0 as a possible value of the URL parameter.
reference: "https://phabricator.wikimedia.org/T211545"
start: "2018-12-12 00:00:00"
end: "2018-12-25 23:59:59"
buckets:
- "5to300_0"
- "5to300"
- "5to100"
- "15to250"
Expand Down
4 changes: 3 additions & 1 deletion src/Factories/ChoiceFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ public function getMembershipCallToActionTemplate(): string {
}

public function getAmountOption(): array {
if ( $this->featureToggle->featureIsActive( 'campaigns.amount_options.5to300' ) ) {
if ( $this->featureToggle->featureIsActive( 'campaigns.amount_options.5to300_0' ) ) {
return $this->getAmountOptionInEuros( [ 500, 1500, 2500, 5000, 7500, 10000, 25000, 30000 ] );
} elseif ( $this->featureToggle->featureIsActive( 'campaigns.amount_options.5to300' ) ) {
return $this->getAmountOptionInEuros( [ 500, 1500, 2500, 5000, 7500, 10000, 25000, 30000 ] );
} elseif ( $this->featureToggle->featureIsActive( 'campaigns.amount_options.5to100' ) ) {
return $this->getAmountOptionInEuros( [ 500, 1000, 1500, 2000, 3000, 5000, 7500, 10000 ] );
Expand Down