Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JS issues with bank data validation #568

Merged
merged 2 commits into from
Jul 26, 2016
Merged

Fix JS issues with bank data validation #568

merged 2 commits into from
Jul 26, 2016

Conversation

KaiNissen
Copy link
Contributor

@KaiNissen KaiNissen commented Jul 15, 2016 •
edited
Loading

  • first commit excludes some fields from triggering the validation
  • second commit gets rid of setting/unsetting the required attribute which was used for HTML5 form validation

phab:T140476

@gbirke gbirke merged commit f6ee979 into master Jul 26, 2016
@gbirke gbirke deleted the fix-js branch July 26, 2016 10:55
@KaiNissen KaiNissen mentioned this pull request Jul 27, 2016
Merged
gbirke added a commit that referenced this pull request Jul 28, 2016
@gbirke
Fix IBAN conversion validation
a8f659d 
The forms were sending empty fields to the server, sometimes even
incorrect fields (See https://phabricator.wikimedia.org/T141381). This
was introduced by #568,
which was not the correct fix for the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@KaiNissen @gbirke