Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature tests for multistep forms #102

Merged
merged 1 commit into from May 25, 2023
Merged

Add feature tests for multistep forms #102

merged 1 commit into from May 25, 2023

Conversation

Abban
Copy link
Member

@Abban Abban commented May 22, 2023

  • Add tests for the different form flows
  • Removes form controller references from banner tests
  • Update desktop content feature to split test signatures
  • Add workaround to vue test-utils for catching form submits in sub-components

Copy link
Member

@gbirke gbirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these integration tests - they'll run faster than the Dandy tests and will make sure that the permutations of the form flow are as expected, while keeping duplication to a minimum.

We'll have to see how many form permutations we have in test/features/forms. My suggestion would be as follows:

  1. Have one file for a combination of components
  2. If you need a new method for a transition/state change for a specific step controller, put it in the file.

We'll also need to talk in the team if we want to archive the tests together with the banners. If we do that (and I'd suggest we do), we'll need to figure out a folder structure that

  1. Allows for easy moving of files without adaptation of input paths
  2. Allows us to run old tests
  3. But only runs tests on demand / in CI to avoid test times becoming longer and longer

@Abban Abban force-pushed the form-feature-tests branch 2 times, most recently from 931bb5d to 8d71359 Compare May 23, 2023 12:42
* Add tests for the different form flows
* Removes form controller references from banner tests
* Update desktop content feature to split test signatures
* Add workaround to vue test-utils for catching form submits
  in sub-components
@Abban Abban merged commit 1a207fb into tracking May 25, 2023
1 check passed
@Abban Abban deleted the form-feature-tests branch May 25, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants