Add CI step to drone #256
Merged
Add CI step to drone #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abban
force-pushed
the
drone-ci
branch
9 times, most recently
from
da24e72
to
075743c
Compare
|
I assume these changes belongs to this ticket https://phabricator.wikimedia.org/T254880 |
|
Yep, whoops forgot to add the details when I hit ready for review. |
moiikana
requested changes
Feb 29, 2024
|
Should be running now |
moiikana
approved these changes
Feb 29, 2024
This moves our content tests to Drone and adds a new test to make sure the message files are valid json. Ticket: https://phabricator.wikimedia.org/T254880
|
as far as I understand, for building with composer, drone will download and install those composer dependencies for every change now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves our content tests to Drone and adds a new
test to make sure the message files are valid json.
Ticket: https://phabricator.wikimedia.org/T254880