[WIP] Optimize all matchers for performance

[thiemowmde]

No description provided.

[manicki]

Out of curiosity: as this mentions performance, do you have any numbers or so regarding the performance?

[thiemowmde]

I rebased this after #12 got merged.

Unfortunately the performance gain is much smaller than I was hoping for.

You see, what this patch does is adding shortcuts to code paths doing a trivial string equality check. Instead of wrapping strings in IsEqual matchers, the string is kept. Most notably this allows to use DOMElement::getElementsByTagName, which is a hash lookup. Before this code path always iterated all child elements in a naive loop.

Unfortunately the new code path can only be hit when the name of the child element is provided as a string, e.g. havingChild( 'input' ). But this is not what is done in our tests. Instead all relevant tests do something like this: havingChild( both( withTagName( 'input' ) )->andAlso( withAttribute( …. To optimize this I would need to make changes to both, which is part of the upstream Hamcrest library. :-(

An alternative approach is to introduce something like havingTag( $tagName )->withAttribute( …, which can be used without both.