This repository has been archived by the owner on Jul 20, 2019. It is now read-only.
Add TermStoreSchemaUpdater class #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeroenDeDauw
force-pushed
the
SchemaUpdater
branch
4 times, most recently
from
879c09b
to
fe0d519
Compare
We need to be able to create the schema before we can add functionality that uses the schema. Followed the same patterns as the schema updating code in Wikibase Repo, eg DatabaseSchemaUpdater
JeroenDeDauw
force-pushed
the
SchemaUpdater
branch
from
fe0d519
to
9a47ef4
Compare
JeroenDeDauw
commented
May 5, 2019
| wbx_text VARBINARY(255) NOT NULL | ||
| ) /*$wgDBTableOptions*/; | ||
|
|
||
| CREATE UNIQUE INDEX /*i*/wbt_text_text ON /*_*/wbt_text (wbx_text); |
There was a problem hiding this comment.
This file is an unchanged copy of what is in Wikibase.git master, except for the above index, which was renamed from wbt_text. The test caught that the index had the same name as the table.
thiemowmde
reviewed
May 6, 2019
| -- index that includes items as well, but rather a very small one. | ||
| -- - conceptually, items and properties are two different entity types, and | ||
| -- since different entity types might have different constraints and maybe | ||
| -- even structure, splitting them into corrisponding tables saves us from |
| -- | ||
| -- Note on Entity IDs: | ||
| -- ------------------ | ||
| -- Since wikidata entity ids are fixed and known to always be Q (like in Q123), |
There was a problem hiding this comment.
This sentence uses the term "entity" in a confusing way. For what this codebase currently cares about, only Item IDs and Property IDs are known to be prefixed integers. Saying that (all) "wikidata entity ids are fixed" can be very confusing. It would be good to avoid the terminology "Entity ID" here.
| ) /*$wgDBTableOptions*/; | ||
|
|
||
| CREATE INDEX /*i*/wbt_text_in_lang_language ON /*_*/wbt_text_in_lang (wbxl_language); | ||
| CREATE UNIQUE INDEX /*i*/wbt_text_in_lang_text_id_text_id ON /*_*/wbt_text_in_lang (wbxl_text_id, wbxl_language); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be able to create the schema before
we can add functionality that uses the schema.
Followed the same patterns as the schema updating code
in Wikibase Repo, eg DatabaseSchemaUpdater