Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update vite to version 3.0.1 (#253)" #261

Merged
merged 1 commit into from Aug 3, 2022
Merged

Conversation

lucaswerkmeister
Copy link
Member

Vite 3 requires Node v14.18 or higher, which we don’t have in CI yet.

This reverts commit 8bfc8b5.

Vite 3 requires Node v14.18 or higher, which we don’t have in CI yet.

This reverts commit 8bfc8b5.
@lucaswerkmeister lucaswerkmeister requested a review from a team August 3, 2022 10:24
@github-actions
Copy link

github-actions bot commented Aug 3, 2022

@lucaswerkmeister lucaswerkmeister merged commit 9e508e9 into main Aug 3, 2022
@lucaswerkmeister lucaswerkmeister deleted the vite2 branch August 3, 2022 10:40
@micgro42
Copy link
Collaborator

micgro42 commented Aug 3, 2022

Redoing this upgrade is tracked in T314468

lucaswerkmeister added a commit that referenced this pull request Sep 9, 2022
Per #261 (9e508e9), we need to stay on Vite 2 until Wikimedia CI has
Node v14.18 or higher.

This reverts commit e758f56.

Bug: T314468
lucaswerkmeister added a commit that referenced this pull request Sep 12, 2022
Per #261 (9e508e9), we need to stay on Vite 2 until Wikimedia CI has
Node v14.18 or higher.

This reverts commit e758f56.

Bug: T314468
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants