Fix anon edit warning message styling #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
they were in the wrong component! Bug: T312652
micgro42
reviewed
Aug 23, 2022
| @@ -26,5 +26,7 @@ const config = useConfig(); | |||
|
|
|||
| .wbl-snl-anonymous-edit-warning { | |||
| margin: $dimension-spacing-small 0; | |||
| margin-top: 1rem; | |||
There was a problem hiding this comment.
no, these lines are now just overriding what is in the line above
micgro42
reviewed
Aug 23, 2022
micgro42
approved these changes
Aug 23, 2022
wmfgerrit
pushed a commit
to wikimedia/mediawiki-extensions-WikibaseLexeme
that referenced
this pull request
Aug 24, 2022
This is mostly to make sure no unnecessary margins come to be in other areas of the inforpanel due to unsustainable :first-child use Added built warning message styling fix from PR #266 (wmde/new-lexeme-special-page#266) Bug: T312652 Change-Id: Ie471cc4d8033220da361a563c681d147266613e7
wmfgerrit
pushed a commit
to wikimedia/mediawiki-extensions
that referenced
this pull request
Aug 24, 2022
* Update WikibaseLexeme from branch 'master'
to b4c402f421262d0dbb02aa9b41e69e07347d0cbb
- Lexidata: add class names and margins to infopanel elements
This is mostly to make sure no unnecessary margins
come to be in other areas of the inforpanel due to
unsustainable :first-child use
Added built warning message styling fix from PR #266
(wmde/new-lexeme-special-page#266)
Bug: T312652
Change-Id: Ie471cc4d8033220da361a563c681d147266613e7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
they were in the wrong component!
Bug: T312652