Use the language search profile if available #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micgro42
force-pushed
the
useSearchProfiles
branch
from
237da63
to
95cc5a6
Compare
micgro42
force-pushed
the
useSearchProfiles
branch
from
95cc5a6
to
49a0c3c
Compare
| public async searchItems( searchTerm: string, offset?: number ): Promise<SearchedItemOption[]> { | ||
| const additionalParams: Record<string, string> = {}; | ||
| if ( this.availableSearchProfiles.includes( this.LANGUAGE_PROFILE_NAME ) ) { | ||
| additionalParams.profile = this.LANGUAGE_PROFILE_NAME; |
There was a problem hiding this comment.
We could also move this into the constructor, right? (And then maybe even discard this.availableSearchProfiles.)
There was a problem hiding this comment.
Not sure if I fully understand what you are suggesting. I adjusted it a bit. Let me know what you think
There was a problem hiding this comment.
What I had in mind was that even the additionalParams could be a class member, but I’m also okay with just having the useLanguageProfile boolean there.
Co-authored-by: Lucas Werkmeister <lucas.werkmeister@wikimedia.de>
Co-authored-by: Lucas Werkmeister <lucas.werkmeister@wikimedia.de>
lucaswerkmeister
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: T312853