Go to newly created Lexeme #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itamargiv
reviewed
Mar 21, 2022
| private readonly getUrl: MwUtilGetUrl; | ||
|
|
||
| public constructor( | ||
| getUrl: MwUtilGetUrl, |
There was a problem hiding this comment.
While I understand why this is injected here, it is not self-evident why we would need to inject a service that gets / generates a URL for us (and why this is better than just having a base URL as a config instead and constructing the URL ourselves). Therefore, I think it would be beneficial to anyone reading this code in the future if a comment was added to document this dependency.
There was a problem hiding this comment.
That is a good point! Though I feel I'm not at my most eloquent today. I added a first comment, but I'd be happy about ideas for how to improve it
micgro42
requested review from
lucaswerkmeister,
chukarave,
guergana and
itamargiv
|
I think this is now also ready for review. Happy to hear any suggestions for improvement :) |
itamargiv
reviewed
Mar 22, 2022
lucaswerkmeister
previously approved these changes
Mar 23, 2022
Also remove a stray import. No idea how that got *there*.
Co-authored-by: Itamar Givon <itamar.givon.dev@gmail.com>
We don't need it for now. We can partially readd it when we need it for getPageUrl.
|
(rebased on top of main) |
The plugin code is itself not related to MediaWiki, so it should live with the agnostic interface. Especially, since it only mentions that interface but not any specific implementation.
lucaswerkmeister
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo:
Bug: T304397