Parse method calls more leniently #26
Conversation
Allow the expression in the single argument to be anything at all, as long as there’s a matching closing parenthesis at the end. Because we don’t support binary operators or multiple arguments, we don’t need to worry about counting balanced parentheses or anything like that: if the close-paren at the very end of the string doesn’t belong to the open-paren at the beginning of the method call, then there must be a syntax error (or unsupported syntax) somewhere.
|
I’d noticed while writing the tests for #25 that |
Hang on, or maybe I just did it wrong and had actually tried |
|
Yeah, that’s it – the old regex did support single-quoted strings inside. But still, this adds support for nested method calls at least. |
|
I don’t plan to continue any further – I think we can tag the 2.0.0 after merging this and then probably not look at this repo again in quite a while (unless we want to move a way from Travis CI, maybe). |
Allow the expression in the single argument to be anything at all, as long as there’s a matching closing parenthesis at the end. Because we don’t support binary operators or multiple arguments, we don’t need to worry about counting balanced parentheses or anything like that: if the close-paren at the very end of the string doesn’t belong to the open-paren at the beginning of the method call, then there must be a syntax error (or unsupported syntax) somewhere.