Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor documentation fixups #5

Merged
merged 1 commit into from
Feb 14, 2018
Merged

Minor documentation fixups #5

merged 1 commit into from
Feb 14, 2018

Conversation

thiemowmde
Copy link
Contributor

@thiemowmde thiemowmde commented Feb 13, 2018 •
edited
Loading

After #3 got merged, not much is left from what this patch originally wanted to do, except:

  • Update the license tag according to the new SPDX version 3.
  • Remove one redundant PHPDoc block.
  • Improve a few type hints.
  • Add newlines between all @param and @return for consistency and clarity.

@thiemowmde thiemowmde mentioned this pull request Feb 14, 2018
Merged
manicki
manicki reviewed Feb 14, 2018
View reviewed changes
tests/php/TemplatingTest.php Outdated
@@ -6,6 +6,9 @@
use PHPUnit_Framework_TestCase;
use WMDE\VueJsTemplating\Templating;

/**
* @license GPL-2.0-or-later
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is GPL 2.0 or later the same thing as LGPL 2.1 this library is licensed under?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that’s a pretty big difference…

lucaswerkmeister
lucaswerkmeister requested changes Feb 14, 2018
View reviewed changes
Copy link
Member

@lucaswerkmeister lucaswerkmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the license issue Leszek pointed out.

tests/php/TemplatingTest.php Outdated
@@ -6,6 +6,9 @@
use PHPUnit_Framework_TestCase;
use WMDE\VueJsTemplating\Templating;

/**
* @license GPL-2.0-or-later
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that’s a pretty big difference…

@thiemowmde thiemowmde changed the title Update Wikibase CodeSniffer to version 0.3 Minor documentation fixups Feb 14, 2018
@thiemowmde
Copy link
Contributor Author

Rebased, fixed, and rewrote the commit message.

@lucaswerkmeister lucaswerkmeister merged commit 73767ca into master Feb 14, 2018
@lucaswerkmeister lucaswerkmeister deleted the wikibaseCs03 branch February 14, 2018 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manicki manicki manicki left review comments

@lucaswerkmeister lucaswerkmeister lucaswerkmeister approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thiemowmde @lucaswerkmeister @manicki