This repository has been archived by the owner on Dec 16, 2020. It is now read-only.
Fix project column bug. #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was bug https://phabricator.wikimedia.org/T102777 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug appeared whenever the last column move of a task happened on a worboard other than the sprint's own workboard and the column's name was the same as one of sprint workboard columns (e.g. Done).
Phragile would then use the PHID of the other workboard's column too look up at what date a task was moved on the sprint workboard and not find anything. The tasks' statuses were still correct since the names were the same but the
closedTimelookup failed.