This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
implemented remove condition #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
guergana
commented
Dec 22, 2020
guergana
commented
- quiet button will be added when new version of wikit is released
- added removeCondition action and mutation
- added tests
micgro42
reviewed
Jan 4, 2021
| @@ -19,12 +19,19 @@ | |||
| :placeholder="$i18n('query-builder-input-value-placeholder')" | |||
| :disabled="isTextInputDisabled()" | |||
| /> | |||
| <Button | |||
There was a problem hiding this comment.
This should probably be its own simple subcomponent as well, similar to ValueTypeDropdown and PropertyLookup. The idea is to try to maintain "one level of abstraction" within the template as well.
But that could also be done in a follow-up pull request
There was a problem hiding this comment.
Let's do it in a followup. :)
tests/unit/store/mutations.spec.ts
Outdated
| conditionId: '0.123', | ||
| }; | ||
| const state: RootState = { | ||
| conditionRows: [ { |
There was a problem hiding this comment.
You can replace this first object with the keptRow variable from above :)
+ quiet button will be added when new version of wikit is released + added removeCondition action and mutation + added tests
guergana
force-pushed
the
removeCondition
branch
from
cc18799
to
5b9759c
Compare
micgro42
approved these changes
Jan 4, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.