Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game: Improve display of extracted data #58

Merged
merged 5 commits into from
May 20, 2020

Conversation

itamargiv
Copy link
Member

@itamargiv itamargiv commented May 20, 2020

  • Rephrased game question T252937
  • Separated each extracted datum into it's own box T252790
  • Re-encoded complex values (arrays and objects) into json T252790
  • Fixed json encoding for slashes and unicode chars T252792

To validate, please visit: https://tools.wmflabs.org/wd-ref-island/test.php?branch=game-pretty-data

Super Important Note: This branch is based on PR #52 and therefore is still marked as WIP. Once that branch is merged to master, I will rebase this branch so it will be ready to merge.

Bug: T252937
Bug: T252790
Bug: T252792

@itamargiv itamargiv changed the base branch from master to game-readable-values May 20, 2020 08:09
@itamargiv itamargiv changed the base branch from game-readable-values to master May 20, 2020 08:31
@itamargiv itamargiv changed the base branch from master to game-readable-values May 20, 2020 09:14
@itamargiv itamargiv changed the title WIP: T252790 [WIP] Game: Improve display of extracted data May 20, 2020
@itamargiv itamargiv requested a review from tarrow May 20, 2020 09:27
@itamargiv itamargiv changed the title [WIP] Game: Improve display of extracted data Game: Improve display of extracted data May 20, 2020
@itamargiv itamargiv merged commit ed973bb into game-readable-values May 20, 2020
@itamargiv itamargiv deleted the game-pretty-data branch May 20, 2020 16:39
tarrow pushed a commit that referenced this pull request May 25, 2020
Reordered sections in tile T252782
Added Item, Property and Value Formatting T252854, T252785
Removed Item Previews
Enabled clickable URLs T252935

Bug: T252782
Bug: T252854
Bug: T252785
Bug: T252935

Squashed from:


* Separate description and values

* Make property readable

* Make item readable

* Cleanup tiles

* Separate Lines

* Beef up source data to match previous version

* Clean-up unused code

* Game: Improve display of extracted data (#58)

* Rephrase game question

* Improve display of extracted data

* Unescape unicode

* Capitlize S

* Reformat entity links urls

* Open links in new tab

* Add explanation comment

* Make sure P813 is set in reference blob

Co-authored-by: Amir Sarabadani <Ladsgroup@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants