This repository has been archived by the owner on Apr 13, 2021. It is now read-only.
Simplify row headers #185
Merged
Simplify row headers #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repetition of 202e5fb which was accidentally pushed to the main branch. This commit removes the concept of nested row headers. Originally created for tables and row spans, then trying to display horizontal headers, the algorithm in `createRowHeaders` that tried to build the data structure for the headers was not working properly. The new concept uses the first element of the Y-Axis sorting order array as the header and displays all other information beneath each screenshot.
Abban
approved these changes
Apr 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the concept of nested row headers. Originally
created for tables and row spans, then trying to display horizontal
headers, the algorithm in
createRowHeadersthat tried to build thedata structure for the headers was not working properly.
The new concept uses the first element of the Y-Axis sorting order array
as the header and displays all other information beneath each
screenshot.
Repetition of 202e5fb which was
accidentally pushed to the main branch.