Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do all backups under /backups + add cleanup script #15

Merged
merged 2 commits into from May 17, 2022
Merged

Do all backups under /backups + add cleanup script #15

merged 2 commits into from May 17, 2022

Conversation

toban
Copy link
Contributor

@toban toban commented May 5, 2022 •
edited

everything will now happen under /backups

  • Stops using the raw files for validating in CI
  • enables DO_UPLOAD to move the files to the docker mount for CI

@toban toban changed the title This stops using /tmp as a storage point for making backups 3. This stops using /tmp as a storage point for making backups May 5, 2022
@toban toban force-pushed the add-some-docs-on-env-vars branch from 2a4ffea to 1a402ad Compare May 5, 2022 07:46
@toban toban force-pushed the move-scratch-to-single-directory branch from 17f5f79 to cf178d9 Compare May 5, 2022 07:46
@toban toban mentioned this pull request May 5, 2022
Merged
@toban toban force-pushed the move-scratch-to-single-directory branch 8 times, most recently from 455799a to f7cdcea Compare May 10, 2022 09:58
@toban toban changed the title 3. This stops using /tmp as a storage point for making backups 3. Do all backups under /backup + add cleanup script May 10, 2022
@toban toban changed the title 3. Do all backups under /backup + add cleanup script 3. Do all backups under /backups + add cleanup script May 10, 2022
@toban toban force-pushed the add-some-docs-on-env-vars branch from 1a402ad to 9d2de12 Compare May 10, 2022 10:04
@toban toban changed the title 3. Do all backups under /backups + add cleanup script Do all backups under /backups + add cleanup script May 10, 2022
Base automatically changed from add-some-docs-on-env-vars to main May 10, 2022 10:07
@toban toban force-pushed the move-scratch-to-single-directory branch from f7cdcea to be773cb Compare May 10, 2022 10:07
@toban toban marked this pull request as ready for review May 10, 2022 10:10
@toban
Copy link
Contributor Author

toban commented May 10, 2022 •
edited

this requires a new v0.1.7 tag to be pushed after merged

rosalieper
rosalieper approved these changes May 17, 2022
View reviewed changes
Copy link

@rosalieper rosalieper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toban toban merged commit 9d97bf1 into main May 17, 2022
@toban toban deleted the move-scratch-to-single-directory branch May 17, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosalieper rosalieper rosalieper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@toban @rosalieper