Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We're using the service.app.url incorrectly #205

Merged
merged 13 commits into from Apr 8, 2022
Merged

Conversation

toban
Copy link
Contributor

@toban toban commented Apr 8, 2022

api url and then passing it down to the ui.

This introduces the services.app.apiUrl variable and uses that for the
urls that should point to the api instead.

@toban toban changed the title We're using the service.app.url incorrectly by setting this to be the We're using the service.app.url incorrectly Apr 8, 2022
We're using the service.app.url incorrectly by setting this to be the
api url and then passing it down to the ui.

This introduces the `services.app.apiUrl` variable and uses that for the
urls that should point to the api instead.
Copy link
Contributor

@deer-wmde deer-wmde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update: I did a rebase to fix this

Generally looks good to me but I get this (unrelated?) change in Terraform for staging if I run terraform plan with this branch checked out.

Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  # module.staging-buckets.google_storage_bucket.sql-backup will be updated in-place
  ~ resource "google_storage_bucket" "sql-backup" {
        id                          = "wikibase-dev-sql-backup"
        name                        = "wikibase-dev-sql-backup"
        # (11 unchanged attributes hidden)


      + retention_policy {
          + is_locked        = false
          + retention_period = 604700
        }
        # (1 unchanged block hidden)
    }


toban and others added 2 commits April 8, 2022 17:15
We're using the service.app.url incorrectly by setting this to be the
api url and then passing it down to the ui.

This introduces the `services.app.apiUrl` variable and uses that for the
urls that should point to the api instead.
@deer-wmde deer-wmde merged commit b77bee8 into main Apr 8, 2022
@deer-wmde deer-wmde deleted the fix-reused-variable branch April 8, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants