Set MW_LOG_TO_STDERR to 'yes' in local env
#62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should also have the new chart version used, and also the new image version used when it is tagged. |
addshore
reviewed
Oct 22, 2021
addshore
reviewed
Oct 22, 2021
addshore
reviewed
Oct 22, 2021
addshore
reviewed
Oct 22, 2021
| @@ -128,7 +128,7 @@ releases: | |||
| - name: mediawiki-135 | |||
| namespace: default | |||
| chart: wbstack/mediawiki | |||
| version: 0.2.0 | |||
| version: 0.3.0 | |||
There was a problem hiding this comment.
Looks good.
This will bump both local and prod charts at the same time, and thus we should apply to both local and prod on merging this.
Co-authored-by: addshore <addshore@users.noreply.github.com>
…nto enable-local-logging
addshore
reviewed
Oct 25, 2021
| webapi: "main@sha256:f75aee2d962c4711b414c2a0571568ded9738c39c5d29483d7c7c8f6c8431f23" | ||
| backend: "main@sha256:f75aee2d962c4711b414c2a0571568ded9738c39c5d29483d7c7c8f6c8431f23" | ||
| alpha: "main@sha256:f75aee2d962c4711b414c2a0571568ded9738c39c5d29483d7c7c8f6c8431f23" | ||
| image: | ||
| pullPolicy: Always |
There was a problem hiding this comment.
We can also remove the override pullPolicy and just use what is in the chart!
addshore
reviewed
Oct 25, 2021
Remove pull policy, use definition in chart Co-authored-by: addshore <addshore@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See T293363 and wbstack/mediawiki#137