tf: uptime for CirrusSearch backed MediaWiki api #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add uptime check and alert to uptime module for a mediawiki api endpoint that depends on being able to contact elasticsearch. This endpoint was chosen because it appears to always contact elasticsearch in order to obtain the mapping. In order to determine success or failure we have to inspect the actual JSON response from the api since even errors return an HTTP status 200. Doing this has resulted in exposing more of the underlying resources to the local configuration and added to the complexity of reading the resource and the module variables. However, it does ensure consistency with our other uptime checks and alerts. This commit doesn't see this module actually being used
m90
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add uptime check and alert to uptime module for a
mediawiki api endpoint that depends on being able to contact elasticsearch.
This endpoint was chosen because it appears to always contact elasticsearch in order to obtain the mapping.
In order to determine success or failure we have to inspect the actual JSON response from the api since even errors return an HTTP status 200.
Doing this has resulted in exposing more of the underlying resources to the local configuration and added to the complexity of reading the resource and the module variables. However, it does ensure consistency with our other uptime checks and alerts.
This commit doesn't see this module actually being used