Optimize image size #183
Merged
Optimize image size #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This optimizes the image size by avoiding the creation of redundant layers for each RUN. Bug: T283174
itamargiv
force-pushed
the
optimize-image-size
branch
26 times, most recently
from
e8d3756
to
377961e
Compare
This commit adds ignore rules for any existing hadolint issues, which remain outside the scope of the current task and should probably be tackled at some other time. Bug: T283240
itamargiv
force-pushed
the
optimize-image-size
branch
from
377961e
to
1a18a77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds dockerfile linting to CI and updates some Dockerfiles to optimize their resulting image size.
In order to enable recursive - multi file linting, some changes were required in the official hadolint github action, which was forked and upstreamed to hadolint/hadolint-action/pull/34. If and when this PR is merged, the GitHub action for linting dockerfiles must be updated.
Followup for TODO: https://phabricator.wikimedia.org/T284069
Bug: T283174 (link)