Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[T280656.THIRD] Add wikibase edtf to bundle for wmde.3 (REL1_36 fall release) #203

Merged
merged 3 commits into from Aug 27, 2021

Conversation

toban
Copy link
Contributor

@toban toban commented Aug 23, 2021

This adds the upcoming wmde.3 version template to use REL1_36 and include WikibaseEdtf.

@toban toban changed the base branch from main to refactor-tests-to-only-run-when-required August 23, 2021 09:36
@toban toban force-pushed the add-wikibase-edtf-to-bundle branch from 872564b to b22f7ae Compare August 23, 2021 09:39
@toban toban force-pushed the refactor-tests-to-only-run-when-required branch from 08edd5b to 12c3ccf Compare August 23, 2021 09:59
@toban toban changed the title [WIP] Add wikibase edtf to bundle for wmde.3 (REL1_36 fall release) [WIP][T280656.THIRD] Add wikibase edtf to bundle for wmde.3 (REL1_36 fall release) Aug 23, 2021
@toban toban force-pushed the add-wikibase-edtf-to-bundle branch from b22f7ae to f29e7bb Compare August 23, 2021 10:11
@toban toban changed the title [WIP][T280656.THIRD] Add wikibase edtf to bundle for wmde.3 (REL1_36 fall release) [T280656.THIRD] Add wikibase edtf to bundle for wmde.3 (REL1_36 fall release) Aug 23, 2021
@toban toban force-pushed the add-wikibase-edtf-to-bundle branch 2 times, most recently from 645bcbc to 9dd8a42 Compare August 23, 2021 14:04
@toban
Copy link
Contributor Author

toban commented Aug 23, 2021

Pipeline was run against wmde.3-alpha and the new test was passed https://github.com/wmde/wikibase-release-pipeline/runs/3401788116?check_suite_focus=true#step:5:15

In the github actions run for this PR it was not executed since it's not apart of wmde.2

@toban toban force-pushed the refactor-tests-to-only-run-when-required branch 4 times, most recently from 592274f to 4e20b00 Compare August 25, 2021 10:56
@toban toban force-pushed the add-wikibase-edtf-to-bundle branch from 9dd8a42 to 2dbee3a Compare August 25, 2021 10:58
@toban
Copy link
Contributor Author

toban commented Aug 25, 2021

Running it again with the new release https://github.com/wmde/wikibase-release-pipeline/actions/runs/1166225372

@lucaswerkmeister
Copy link
Member

Hm, the Property test has failed twice now…

[Chrome Headless 86.0.4240.111 linux #0-1] Property
[Chrome Headless 86.0.4240.111 linux #0-1]    ✖ Should be able to add statement and reference to property
[Chrome Headless 86.0.4240.111 linux #0-1]    ✖ Should contain statement and reference in EntityData
[Chrome Headless 86.0.4240.111 linux #0-1]
[Chrome Headless 86.0.4240.111 linux #0-1] 2 failing (37.5s)
[Chrome Headless 86.0.4240.111 linux #0-1]
[Chrome Headless 86.0.4240.111 linux #0-1] 1) Property Should be able to add statement and reference to property
[Chrome Headless 86.0.4240.111 linux #0-1] element ("=P101 (P101)") still not displayed after 30000ms
[Chrome Headless 86.0.4240.111 linux #0-1] Error: element ("=P101 (P101)") still not displayed after 30000ms
[Chrome Headless 86.0.4240.111 linux #0-1]     at processTicksAndRejections (internal/process/task_queues.js:95:5)
[Chrome Headless 86.0.4240.111 linux #0-1]     at Context.<anonymous> (/usr/src/app/specs/repo/property.js:38:27)
[Chrome Headless 86.0.4240.111 linux #0-1]
[Chrome Headless 86.0.4240.111 linux #0-1] 2) Property Should contain statement and reference in EntityData
[Chrome Headless 86.0.4240.111 linux #0-1] Cannot read property '0' of undefined
[Chrome Headless 86.0.4240.111 linux #0-1] TypeError: Cannot read property '0' of undefined
[Chrome Headless 86.0.4240.111 linux #0-1]     at Context.<anonymous> (/usr/src/app/specs/repo/property.js:52:37)

(Though the second failure just now was in mariadb:10.3, repo, and the first one was in mysql:5.6, repo, if I remember correctly.)

@toban toban force-pushed the refactor-tests-to-only-run-when-required branch from 4e20b00 to a9eb3fb Compare August 27, 2021 11:11
@toban toban force-pushed the add-wikibase-edtf-to-bundle branch 2 times, most recently from 206a98c to 5d27ead Compare August 27, 2021 12:51
@toban toban force-pushed the refactor-tests-to-only-run-when-required branch from e83eedf to 4da58a5 Compare August 27, 2021 13:11
This is a template for the fall release including WikibaseEDTF
Adds override hack for LocalSettings.php in client only setup.
And fixes some review comments.
@toban toban force-pushed the add-wikibase-edtf-to-bundle branch from 5d27ead to fa07a6f Compare August 27, 2021 13:12
Base automatically changed from refactor-tests-to-only-run-when-required to main August 27, 2021 13:58
@lucaswerkmeister lucaswerkmeister merged commit 3e7a1c9 into main Aug 27, 2021
@lucaswerkmeister lucaswerkmeister deleted the add-wikibase-edtf-to-bundle branch August 27, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants