fix: Fix commandline argument passing to runBlazegraph.sh #364
Conversation
|
Great, I can make the changes and get this merged |
|
Scratch that, I can't alter this branch :) |
|
I can make the changes later tonight and also clean up this thread.
|
|
I am unsure as to whether the build failures are related to my changes? Could someone with more experience with the pipeline please advise? |
Re running them now |
This would help debug issues such as #364
|
if you could rebase on #371 the extra log output should help us see what is happening with wdqs |
|
Just checking to inform about the status of this PR. Anything @kwisatz can do to advance this? |
* Always output docker logs in CI This would help debug issues such as #364 * fix path * Actually add file * Fix SC2086
|
@addshore just rebased it |
|
From the more verbose output in CI now I see this |
|
Not sure what happened here, I must have messed up the PR somehow, this is not what I should have in HEAD. I'll look into it. Yup… my mistake. |
|
I believe you need to provide a default var in the image, or the var in In the image probably makes the most sense if the default should be empty and the entrypoint expects it |
|
@addshore which build-step did those appear in earlier? |
|
A note about the env var should also be added to |
This commit fixes two issues in the container scripts that prevented users from passing any options to blazegraph (as document here: https://www.mediawiki.org/wiki/Wikidata_Query_Service/User_Manual#Configurable_properties) This commit changes two things: - Rather than overwrite $BLAZEGRAPH_OPTS in entrypoint.sh, it extends it using $BLAZEGRAPH_EXTRA_OPTS - It modifies the root directoy runBlazegraph.sh to no longer drop all arguments passed to the docker command property
* commit '42951edfd4edd68f112077ba05078934e8a6b8f6': (62 commits) Poke interwiki name and source name Use assert.deepStrictEqual $ is webdriver, not jqeury /o\ mariadb:10.9 Use 1.37.6 Try mw-content-text for edit page content Use assert package consistently Fix test: entityschema.js Use assert.strictEqual in tests debug logging of mw in tests mwlogs, continue on error & cleaner ls output mwlog, more ls output, and no / Poke the logging again... Try outputting mw logs again fix: Fix commandline argument passing to runBlazegraph.sh (wmde#364) Add wgWBClientSettings['itemAndPropertySourceName'] Revert "Revert "Revert "Output MediaWiki logs in CI too""" Revert "More general path for mwlog output" More general path for mwlog output Revert "Revert "Output MediaWiki logs in CI too"" ...
This commit fixes two issues in the container scripts that prevented users from passing any options to blazegraph (as documented here: https://www.mediawiki.org/wiki/Wikidata_Query_Service/User_Manual#Configurable_properties)
This commit changes two things:
$BLAZEGRAPH_OPTSin entrypoint.sh, it extends it using$EXTRA_BLAZEGRAPH_OPTSAn example of setting EXTRA_BLAZEGRAPH_OPTS in the docker-compose files would be for example: