New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T355893 - Rename "whitelist.txt" to "allowlist.txt" #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
RickiJay-WMDE
commented
Mar 27, 2024
•
edited
edited
- Rename whitelist.txt to allowlist.txt
- Add tests to queryservice: federated query to service in allowlist.txt should return results, valid federated query to service not in allowlist.txt should return specific error
RickiJay-WMDE
changed the title
T355893 allowlist
T355893 - Rename "whitelist.txt" to "allowlist.txt"
Mar 27, 2024
rti
reviewed
Mar 28, 2024
physikerwelt
added a commit
to MaRDI4NFDI/portal-compose
that referenced
this pull request
Mar 28, 2024
When wmde/wikibase-release-pipeline#625 we have to remove the custom workaround, when we update the wdws version, currently pinned to ghcr.io/wmde/wikibase/wdqs:7443724965.
5 tasks
lorenjohnson
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
RickiJay-WMDE
added a commit
that referenced
this pull request
Apr 3, 2024
* Rename * References * Fail? * Run * Fail? * Restore * allow * Unrestore * Restore * FINALLY * Comment * Reduce Load * Spacing * Spacing * Skip * Wrong Ticket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.