Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T355893 - Rename "whitelist.txt" to "allowlist.txt" #625

Merged
merged 18 commits into from Apr 3, 2024

Conversation

RickiJay-WMDE
Copy link
Member

@RickiJay-WMDE RickiJay-WMDE commented Mar 27, 2024

  • Rename whitelist.txt to allowlist.txt
  • Add tests to queryservice: federated query to service in allowlist.txt should return results, valid federated query to service not in allowlist.txt should return specific error

@RickiJay-WMDE RickiJay-WMDE changed the title T355893 allowlist T355893 - Rename "whitelist.txt" to "allowlist.txt" Mar 27, 2024
@RickiJay-WMDE RickiJay-WMDE marked this pull request as ready for review March 28, 2024 14:48
@RickiJay-WMDE RickiJay-WMDE requested a review from a team March 28, 2024 14:52
physikerwelt added a commit to MaRDI4NFDI/portal-compose that referenced this pull request Mar 28, 2024
When
wmde/wikibase-release-pipeline#625
we have to remove the custom workaround, when we update the wdws version, currently pinned to  ghcr.io/wmde/wikibase/wdqs:7443724965.
@RickiJay-WMDE RickiJay-WMDE requested review from lorenjohnson and a team April 2, 2024 11:58
Copy link
Contributor

@lorenjohnson lorenjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RickiJay-WMDE RickiJay-WMDE merged commit bd49014 into main Apr 3, 2024
26 checks passed
@RickiJay-WMDE RickiJay-WMDE deleted the T355893-allowlist branch April 3, 2024 08:30
RickiJay-WMDE added a commit that referenced this pull request Apr 3, 2024
* Rename

* References

* Fail?

* Run

* Fail?

* Restore

* allow

* Unrestore

* Restore

* FINALLY

* Comment

* Reduce Load

* Spacing

* Spacing

* Skip

* Wrong Ticket
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants