Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T361227 - Release WMDE.19 #636

Merged
merged 19 commits into from Apr 9, 2024
Merged

T361227 - Release WMDE.19 #636

merged 19 commits into from Apr 9, 2024

Conversation

RickiJay-WMDE
Copy link
Member

No description provided.

RickiJay-WMDE and others added 16 commits April 3, 2024 14:04
* Update Script

* Url Changes

* Move

* Try

* reuse

* Update Mediawiki Version, Simplify

* user_approves()

* Build Step

* Separate

* Build Parameter

* fix: update hashes script (#589)

* docs: updating hints in variables.env (#591)

* docs: updating hints in variables.env

* fix: revert hash change

* docs: notes about automatic updating

* docs: review changes url

* fix(update_commits): support _COMMIT vars with underscore (#592)

* Test Success (#594)

* docs: comment leftover (#595)

* T359284 If and only if (#615)

* If

* On PR

* Exclude

* Boolean (#619)

* Undo Update

* Deprecated

* Retries

---------

Co-authored-by: Robert Timm <mail@rtti.de>
Co-authored-by: rti <rti@users.noreply.github.com>
@RickiJay-WMDE RickiJay-WMDE changed the title Releaseprep wmde.19 Release WMDE.19 Apr 4, 2024
@RickiJay-WMDE RickiJay-WMDE changed the title Release WMDE.19 T361227 - Release WMDE.19 Apr 4, 2024
@RickiJay-WMDE RickiJay-WMDE marked this pull request as ready for review April 4, 2024 12:07
@RickiJay-WMDE RickiJay-WMDE requested a review from a team April 4, 2024 12:13
Copy link
Contributor

@lorenjohnson lorenjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit hashes updated here are they derived via the automatic script, or manually? I think for the patch releases we have to be careful about using the automatic script as latest / HEAD versions of each of the extensions, etc aren't necessarily compatible with previous major MediaWiki releases. It probably was, but confirming that this was considered here?

RickiJay-WMDE and others added 2 commits April 8, 2024 12:25
* Release 1.39.6 (#568)

* Lint

---------

Co-authored-by: adeeri <132473526+adeeri@users.noreply.github.com>
* docs: update changes.md

---------

Co-authored-by: Ricki Jay <ricki.jay@wikimedia.de>
@RickiJay-WMDE
Copy link
Member Author

RickiJay-WMDE commented Apr 8, 2024

The commit hashes updated here are they derived via the automatic script, or manually? I think for the patch releases we have to be careful about using the automatic script as latest / HEAD versions of each of the extensions, etc aren't necessarily compatible with previous major MediaWiki releases. It probably was, but confirming that this was considered here?

@lorenjohnson

All the WMF extensions are branched by MW version - we're only pulling updates from their 1.40 branches.
WDQS Frontend isn't, but in my experience so far it doesn't built when it isn't compatible with the MW version. I've been working on checking that and so far it holds.

@RickiJay-WMDE RickiJay-WMDE requested review from a team and lorenjohnson April 8, 2024 12:26
Copy link
Contributor

@lorenjohnson lorenjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@RickiJay-WMDE RickiJay-WMDE merged commit b005cf8 into mw-1.40 Apr 9, 2024
28 checks passed
@RickiJay-WMDE RickiJay-WMDE deleted the releaseprep-wmde.19 branch April 9, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants