store: implement LANGUAGE_UPDATE mutation

Add the LANGUAGE_UPDATE mutation and use it with dummy data from the LANGUAGE_INIT action Bug: T210407
wmde · Dec 11, 2018 · c2629e9 · c2629e9
1 parent 79be4fc
commit c2629e9
Show file tree

Hide file tree

Showing 6 changed files with 105 additions and 6 deletions.
diff --git a/dist/wikibase.termbox.main.js b/dist/wikibase.termbox.main.js
diff --git a/src/store/language/actions.ts b/src/store/language/actions.ts
@@ -1,14 +1,34 @@
 import { ActionContext, ActionTree } from 'vuex';
 import { LANGUAGE_INIT, ENSURE_AVAILABLE_IN_LANGUAGE } from './actionTypes';
-import { LANGUAGE_TRANSLATION_UPDATE } from './mutationTypes';
+import {
+	LANGUAGE_TRANSLATION_UPDATE,
+	LANGUAGE_UPDATE,
+} from './mutationTypes';
 import { factory } from '@/common/TermboxFactory';
 import LanguageState from '@/store/language/LanguageState';
 import LanguageTranslations from '@/datamodel/LanguageTranslations';
+import LanguageCollection from '@/datamodel/LanguageCollection';
 
 export const actions: ActionTree<LanguageState, any> = {
 
 	[ LANGUAGE_INIT ]( context: ActionContext<LanguageState, any> ): Promise<void> {
+		// TODO commit dynamic list from upstream source
 		// TODO same api. how to do only one call?
+		context.commit( LANGUAGE_UPDATE, {
+			en: {
+				code: 'en',
+				directionality: 'ltr',
+			},
+			de: {
+				code: 'de',
+				directionality: 'ltr',
+			},
+			ar: {
+				code: 'ar',
+				directionality: 'rtl',
+			},
+		} as LanguageCollection );
+
 		return Promise.resolve();
 	},
 

diff --git a/src/store/language/mutationTypes.ts b/src/store/language/mutationTypes.ts
@@ -1 +1,2 @@
 export const LANGUAGE_TRANSLATION_UPDATE: string = 'translationUpdate';
+export const LANGUAGE_UPDATE: string = 'languageUpdate';
diff --git a/src/store/language/mutations.ts b/src/store/language/mutations.ts
@@ -1,11 +1,19 @@
 import { MutationTree } from 'vuex';
 import {
 	LANGUAGE_TRANSLATION_UPDATE,
+	LANGUAGE_UPDATE,
 } from './mutationTypes';
 import LanguageState from '@/store/language/LanguageState';
 import LanguageTranslations from '@/datamodel/LanguageTranslations';
+import LanguageCollection from '@/datamodel/LanguageCollection';
 
 export const mutations: MutationTree<LanguageState> = {
+	[ LANGUAGE_UPDATE ]( state: LanguageState, languages: LanguageCollection ): void {
+		Object.entries( languages ).forEach( ( [ languageKey, localData ] ) => {
+			state.languages[ languageKey ] = localData;
+		} );
+	},
+
 	[ LANGUAGE_TRANSLATION_UPDATE ]( state: LanguageState, translations: LanguageTranslations ): void {
 		Object.entries( translations ).forEach( ( [ languageKey, localTranslations ] ) => {
 			state.translations[ languageKey ] = localTranslations;

diff --git a/tests/unit/store/language/actions.spec.ts b/tests/unit/store/language/actions.spec.ts
@@ -1,20 +1,42 @@
 import { actions } from '@/store/language/actions';
 import { LANGUAGE_INIT, ENSURE_AVAILABLE_IN_LANGUAGE } from '@/store/language/actionTypes';
-import { LANGUAGE_TRANSLATION_UPDATE } from '@/store/language/mutationTypes';
+import {
+	LANGUAGE_TRANSLATION_UPDATE,
+	LANGUAGE_UPDATE,
+} from '@/store/language/mutationTypes';
 import { factory } from '@/common/TermboxFactory';
 import LanguageTranslations from '@/datamodel/LanguageTranslations';
+import LanguageCollection from '@/datamodel/LanguageCollection';
 
 describe( 'language/actions', () => {
 	describe( LANGUAGE_INIT, () => {
-		it( 'does not commit anything yet, just returns a promise', ( done ) => {
+		it( 'commits a fixed set of languages and returns a resolved promise', ( done ) => {
+			const languages = {
+				en: {
+					code: 'en',
+					directionality: 'ltr',
+				},
+				de: {
+					code: 'de',
+					directionality: 'ltr',
+				},
+				ar: {
+					code: 'ar',
+					directionality: 'rtl',
+				},
+			} as LanguageCollection;
+
 			const commitMock = jest.fn();
 			const context = {
 				commit: commitMock,
 			};
 			const action = actions[ LANGUAGE_INIT ] as any; // TODO
 
 			action( context ).then( () => {
-				expect( commitMock ).not.toBeCalled();
+				expect( commitMock ).toBeCalledWith(
+					LANGUAGE_UPDATE,
+					languages,
+				);
 				done();
 			} );
 		} );

diff --git a/tests/unit/store/language/mutations.spec.ts b/tests/unit/store/language/mutations.spec.ts
@@ -1,9 +1,11 @@
 import { mutations } from '@/store/language/mutations';
 import {
 	LANGUAGE_TRANSLATION_UPDATE,
+	LANGUAGE_UPDATE,
 } from '@/store/language/mutationTypes';
 import LanguageTranslations from '@/datamodel/LanguageTranslations';
 import LanguageState from '@/store/language/LanguageState';
+import LanguageCollection from '@/datamodel/LanguageCollection';
 
 function newMinimalStore(): LanguageState {
 	return {
@@ -13,6 +15,52 @@ function newMinimalStore(): LanguageState {
 }
 
 describe( 'language/mutations', () => {
+	describe( LANGUAGE_UPDATE, () => {
+		it( 'contains languages after initialization', () => {
+			const store = newMinimalStore();
+			const languages = {
+				de: {
+					code: 'de',
+					directionality: 'ltr',
+				},
+				en: {
+					code: 'en',
+					directionality: 'ltr',
+				},
+			} as LanguageCollection;
+
+			mutations[ LANGUAGE_UPDATE ]( store, languages );
+
+			expect( store.languages.de ).toBe( languages.de );
+			expect( store.languages.en ).toBe( languages.en );
+		} );
+
+		it( 'appends new languages to pre-existing ones', () => {
+			const store = newMinimalStore();
+			const originalDe = {
+				code: 'de',
+				directionality: 'ltr',
+			};
+			store.languages.de = originalDe;
+			const languages = {
+				en: {
+					code: 'en',
+					directionality: 'ltr',
+				},
+				ar: {
+					code: 'ar',
+					directionality: 'rtl',
+				},
+			} as LanguageCollection;
+
+			mutations[ LANGUAGE_UPDATE ]( store, languages );
+
+			expect( store.languages.de ).toBe( originalDe );
+			expect( store.languages.en ).toBe( languages.en );
+			expect( store.languages.ar ).toBe( languages.ar );
+		} );
+	} );
+
 	describe( LANGUAGE_TRANSLATION_UPDATE, () => {
 		// TODO
 		/*