Migrate Ores calls to Liftwing #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itamargiv
reviewed
Sep 23, 2023
There was a problem hiding this comment.
There's more work to be done. I've added a few comments for this round. As a reminder to our takeaways from Friday, please remove the following from the commit:
- All the changes made to components
- All the changes made in the tests.
As for the tests, I think we shall rewrite them in the end. But as a first step, I think we should remove the tests for getOresScores and all the mocks it requires. I think it'll be best to just start from a clean slate when starting to write tests from the methods added in this commit.
|
@itamargiv What's the wisdom about the tests? I removed Ores related mocks and tests, no other changes yet. my current blocker is still failing to make more than one fetch.mock() call in a row: |
itamargiv
approved these changes
Oct 19, 2023
- Adjust scores objects to liftwing response structure - Provide scores from liftwing - Move iteration out of provideScores and clean non-liftwing related stuff from pr - Use jest-fetch-mock and fix tests
This was done to allow us to use ignore rule temporarly until we come around to finish updating IQE's dependencies.
itamargiv
force-pushed
the
ores-to-liftwing
branch
from
ce5ef3f
to
0984bde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement score calculation using Liftwing instead of ORES. This required multiple changes to the ArticleQualityService as Liftwing calls are built differently.
Bug: T343731