Avoid empty results Array in case of no mismatches #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes sure that instead of sending an empty array in the Inertia response, no results field is passed to Results.vue, when no mismatches have been found. This way the results prop's default function will be executed to create an empty object, which prevents an 'Invalid prop' error message, previously caused by the empty array. Bug: T294303
Silvan-WMDE
force-pushed
the
fix/prevent-empty-results-array
branch
from
1bb3f59
to
fe4aacf
Compare
itamargiv
approved these changes
Oct 26, 2021
| 'labels' => $wikidata->getLabels($entityIds, App::getLocale()) | ||
| ], | ||
| // only add 'results' prop if mismatches have been found | ||
| $mismatches->isNotEmpty() ? [ 'results' => $mismatches->groupBy('item_id') ] : [] |
| ->assertViewIs('app') | ||
| ->assertInertia(function (Assert $page) { | ||
| $page->component('Results') | ||
| ->missing('results'); |
There was a problem hiding this comment.
Nice! Our tests even reflected the issue before, which is also good!
There was a problem hiding this comment.
Haha, I guess that's your nice way of saying "our tests were wrong". :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes sure that instead of sending an empty array in the
Inertia response, no results field is passed to Results.vue, when no
mismatches have been found. This way the results prop's default
function will be executed to create an empty object, which prevents an
'Invalid prop' error message, previously caused by the empty array.
Bug: T294303