Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tests more resilient by reusing user in db #459

Merged
merged 1 commit into from Nov 7, 2022
Merged

Make tests more resilient by reusing user in db #459

merged 1 commit into from Nov 7, 2022

Conversation

micgro42
Copy link
Collaborator

@micgro42 micgro42 commented Nov 7, 2022

The hope is, that by not recreating a new user for each test, the loginAs method will work more robustly.

Bug: T311506

@micgro42
Make tests more resilient by reusing user in db
b1697cd 
The hope is, that by not recreating a new user for each test, the
loginAs method will work more robustly.

Bug: T311506
lucaswerkmeister
lucaswerkmeister approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@lucaswerkmeister lucaswerkmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let’s try it

@micgro42 micgro42 marked this pull request as ready for review November 7, 2022 14:50
@micgro42 micgro42 merged commit e104da9 into main Nov 7, 2022
@micgro42 micgro42 deleted the extractUserCreation branch November 7, 2022 14:50
@guergana
Copy link
Contributor

Cool! Let's see how this approach works :) Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaswerkmeister lucaswerkmeister lucaswerkmeister approved these changes

@itamargiv itamargiv Awaiting requested review from itamargiv

@guergana guergana Awaiting requested review from guergana

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@micgro42 @guergana @lucaswerkmeister