Get active mismatches #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add new request parameters include_reviewed and include_expired * adjust tests to new requirements * modify mismatches response to include status * modify API spec according to new requirements Bug: T285301
Silvan-WMDE
force-pushed
the
server/get_active_mismatches
branch
from
31fab91
to
5cfff7a
Compare
Silvan-WMDE
force-pushed
the
server/get_active_mismatches
branch
from
95b669a
to
cfa0012
Compare
itamargiv
requested changes
Aug 18, 2021
| * | ||
| * @return \Illuminate\Database\Eloquent\Factories\Factory | ||
| */ | ||
| public function reviewed() |
There was a problem hiding this comment.
I really like the use of states we have in our factories 👍
database/seeders/MismatchSeeder.php
Outdated
Comment on lines
28
to
43
| Mismatch::factory(10) | ||
| ->for($import) | ||
| ->create(); | ||
|
|
||
| Mismatch::factory(11) | ||
| ->for($expiredImport) | ||
| ->create(); | ||
|
|
||
| Mismatch::factory(10) | ||
| ->for($import) | ||
| ->reviewed() | ||
| ->create(); | ||
|
|
||
| Mismatch::factory(11) | ||
| ->for($expiredImport) | ||
| ->reviewed() |
There was a problem hiding this comment.
10+11+10+11 = 42 Checks out 🤓 😍
| @@ -195,6 +195,14 @@ components: | |||
| type: string | |||
| external_url: | |||
| type: string | |||
| status: | |||
| type: string | |||
| enum: | |||
There was a problem hiding this comment.
💯 Thanks for updating the specs!
Comment on lines
84
to
87
| 'ids' => $pendingMismatches->implode('item_id', '|') . '|' . | ||
| $reviewedMismatches->implode('item_id', '|') . '|' . | ||
| $expiredMismatches->implode('item_id', '|') . '|' . | ||
| $expiredReviewedMismatches->implode('item_id', '|') |
itamargiv
requested changes
Aug 19, 2021
Use private methods to set and get imports, mismatches and their IDs.
Silvan-WMDE
force-pushed
the
server/get_active_mismatches
branch
from
0b2ef97
to
c60ac0d
Compare
itamargiv
approved these changes
Aug 19, 2021
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the /mismatches endpoint, so that it only returns mismatches that have not been edited yet and that do not belong to expired imports. Two optional request parameters are added, which allow including reviewed mismatches or expired ones.
Bug: T285301