Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite MismatchRow in Vue3 script setup syntax #826

Merged
merged 6 commits into from
Jan 9, 2024
Merged

Rewrite MismatchRow in Vue3 script setup syntax #826

merged 6 commits into from
Jan 9, 2024

Commits on Jan 9, 2024

  1. Rewrite MismatchesTable with Vue3 syntax 

    Bug: T354375
    @guergana
    guergana committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    d0ffcb1 View commit details
    Browse the repository at this point in the history

  2. Adjust unit tests to new code

    @guergana
    guergana committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    0c833d5 View commit details
    Browse the repository at this point in the history

  3. Rewrite MismatchRow in Vue3 script setup syntax 

    Some tests are still failing likely because MismatchesTable needs
to be changed in the syntax as well. This PR is rebased on top of
the Results Page PR(#805). Otherwise the tests fail.

Bug: T354346
    @guergana
    guergana committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    384f876 View commit details
    Browse the repository at this point in the history

  4. Remove leftover references to this

    @guergana
    guergana committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    0c419b7 View commit details
    Browse the repository at this point in the history

  5. Remove unused variable and import

    @guergana
    guergana committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    9cef482 View commit details
    Browse the repository at this point in the history

  6. Convert reviewStatus to ref

    @guergana
    guergana committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    a7781cd View commit details
    Browse the repository at this point in the history