Document the wide reaching concept of dispatching #120 #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addshore
requested review from
Silvan-WMDE,
jakobw,
tzhelyazkova,
bereket-WMDE and
tarrow
and removed request for
Silvan-WMDE and
jakobw
jakobw
requested changes
Jun 11, 2021
Concepts.md
Outdated
| A few different implementations of the dispatching pattern currently exist, the most notable difference being: | ||
|
|
||
| - Default / fallback implementation available in some implementations | ||
| - Callbacks passed into dispatching code, rather than concrete implementations |
There was a problem hiding this comment.
People new to Wikibase probably don't know what kind of callbacks this talks about. Would it make sense to mention entity type definitions here or even in the paragraph at the top, or did you leave them out on purpose?
tzhelyazkova
force-pushed
the
concept-dispatching
branch
from
e2f785d
to
ca0566f
Compare
Co-authored-by: Jakob Warkotsch <jakob.warkotsch@wikimedia.de>
tzhelyazkova
force-pushed
the
concept-dispatching
branch
from
ca0566f
to
473c26b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.