Move Chromatic to run on the vue-components package #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We get more value from Chromatic if we run it only against the vue Storybook, because then we can use the UI Review and UI Testing tools.
jakobw
requested changes
Aug 13, 2020
tzhelyazkova
force-pushed
the
vue_chromatic
branch
from
5832d39
to
e8ed175
Compare
Now that we have only the vue storybook on Chromatic there is no need to determine which iframe is shown, because it's always the same one.
tzhelyazkova
force-pushed
the
vue_chromatic
branch
from
e8ed175
to
1c9f5eb
Compare
jakobw
approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explore how component changes affect chromatic T257826
After enabling the UI Review and Visual Tests options on Chromatic, it became clear that they don't work on our composed Storybook, whose main stories are the design system tokens.
After discussing this with UX, we agreed that it's more important to leverage the features Chromatic offers on our vue components and not on our design tokens.
This PR moves chromatic from the
docspackage to thevue-componentspackage.➕ This means the per-branch generated Chromatic URLs will show only the vue components Storybook. It will enable us to run visual tests and use the UI Review feature.
➕ This also means the browser tests no longer need to make a difference between a composed storybook and a local vue components storybook.
➖ The downside is that any token changes cannot be previewed on Chromatic anymore. This can only happen locally.