Make OptionsMenu items controllable in Storybook #304
Conversation
- added optional tag to MenuItem - added tokens for tag - added styling in OptionsMenu.vue - updated OptionsMenu story - updated LookupMenu story - added a unit test
|
Looks good. Why is it a draft? |
When it was created, it was unclear whether people would want it. Setting it ready for review now. |
| @@ -79,12 +74,11 @@ export function withItems( args: { boldLabels: boolean, selectedItemIndex: numbe | |||
|
|
|||
| withItems.args = { | |||
| boldLabels: true, | |||
| menuItems: vegetableItems, | |||
There was a problem hiding this comment.
This control feels a bit cluncky, which makes me question how usable it actually is, maybe we should create a couple of controls for only one item from the list? (i.e. label, description, tag)
Well, first let me say that I'm actually against displaying internal subcomponents (such as the Input or the OptionsMenu) in our Storybook 😑 In my opinion, simply referring/pointing at these from the "finished" component's documentation should be enough. But I understand the engineers' perspective, so I would say that displaying the OptionsMenu in a separate section (as suggested by this PR) might make more sense than other options such as displaying the component several times in its multiple parents' sections; or creating a separate subsection to collect internal components. |
|
Making this a draft again as it needs more conceptual work |
No description provided.