Update button tokens #321
Merged
Update button tokens #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the alias tokens that define the color value of the border and the background of disabled quiet buttons.
This organizes tokens per button variant and flavor.
This was referenced Dec 14, 2020
This defines the required spacing that should exist between the button's icon and its label
the variables used to style the Button.vue are replaced by the new ones derived from the new component tokens file
|
Implementing it in #324 it seems |
sai-san
force-pushed
the
update-button-tokens
branch
from
e7c9c7c
to
0375c22
Compare
sai-san
commented
Dec 17, 2020
The variant names "normal" and "framed" are used interchangeably in the documentation. "Framed" was introduced here to match the naming applied to the WVUI button. But I believe that this change belongs in a different PR.
micgro42
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides the tokens that will be used to style quiet and icon-only buttons.