Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TextArea story #460

Merged

Conversation

itamargiv
Copy link
Member

Note: This PR depends on #459

This change adds documentation for the initial text area component, and a story to display it in WiKit's storybook. Additionally, it adds the value props to the TextArea component, which was missed (yet unneeded) by the Mismatch Finder implementation.

Bug: T289141

@github-actions
Copy link

@itamargiv itamargiv changed the title Add textarea story Add TextArea story Aug 25, 2021
Copy link
Member

@Silvan-WMDE Silvan-WMDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a question, while this is still a draft

vue-components/src/components/TextArea.vue Show resolved Hide resolved
@itamargiv itamargiv marked this pull request as ready for review August 26, 2021 09:11
@itamargiv itamargiv merged commit 47ec755 into components/add-inital-textarea-component Aug 26, 2021
@itamargiv itamargiv deleted the docs/add-textarea-story branch August 26, 2021 09:24
itamargiv added a commit that referenced this pull request Aug 26, 2021
* Upstream TextArea component from Mismatch Finder
* Add TextArea story (#460)

Co-authored-by: Silvan Heintze <59574251+Silvan-WMDE@users.noreply.github.com>
Bug: T289138
Bug: T289141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants