Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve shadow tokens visualization #58

Merged
merged 1 commit into from Jul 7, 2020
Merged

Improve shadow tokens visualization #58

merged 1 commit into from Jul 7, 2020

Conversation

tzhelyazkova
Copy link
Contributor

Style changes are based on feedback from UX provided in T256858

@tzhelyazkova tzhelyazkova changed the base branch from master to reference-style July 6, 2020 13:28
@tzhelyazkova tzhelyazkova requested review from wiese and jakobw July 6, 2020 13:29
Base automatically changed from reference-style to master July 7, 2020 09:11
jakobw
jakobw requested changes Jul 7, 2020
View reviewed changes
Copy link
Member

@jakobw jakobw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated rectangle looks brilliant, but the value is duplicated

docs/src/lib/presenters/Shadows.jsx Outdated Show resolved Hide resolved
@jakobw jakobw merged commit 8d5fac5 into master Jul 7, 2020
@jakobw jakobw deleted the shadows branch July 7, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobw jakobw jakobw approved these changes

@wiese wiese Awaiting requested review from wiese

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@tzhelyazkova @jakobw