Let extra Lookup attributes fall trough to the <input> (#641) #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micgro42
force-pushed
the
cherry-pick-disableAttrInherit
branch
from
354b129
to
c695dba
Compare
Now aria-required can also be handled by this attribute inheritance and no longer needs its own dedicated prop. Bug: T322686
micgro42
force-pushed
the
cherry-pick-disableAttrInherit
branch
from
c695dba
to
194f489
Compare
micgro42
requested review from
chukarave,
guergana,
hasanakg,
lucaswerkmeister and
mariushoch
hasanakg
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now aria-required can also be handled by this attribute inheritance and no longer needs its own dedicated prop.
Bug: T322686