Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry Pick commits to fix warnings on GitHub Action #673

Merged
merged 3 commits into from
Jan 9, 2023

Conversation

micgro42
Copy link
Collaborator

@micgro42 micgro42 commented Jan 9, 2023

This collects the changes of the PRs #643, #665 and #666

Bug: T322548

micgro42 and others added 3 commits January 9, 2023 17:17
This takes care of the following warning appearing in our GitHub CI:

```
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout@v2, dorny/paths-filter@v2.9.0, actions/setup-node@v1, actions/cache@v2
```

This also removes many of the remaining warnings of the type:
```
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
```
and
```
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
```

Bug: T322548
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

micgro42 added a commit that referenced this pull request Jan 9, 2023
This takes care of the following warning appearing in our GitHub CI:

```
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout@v2, dorny/paths-filter@v2.9.0, actions/setup-node@v1, actions/cache@v2
```

It also removes all of the remaining warnings of the type:
```
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
```
and
```
The `save-state` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
```

(this will also has been cherry-picked to the `next` branch in PR #673)

Bug: T322548
@micgro42 micgro42 requested a review from a team January 9, 2023 16:29
@micgro42 micgro42 merged commit 0748a0b into next Jan 9, 2023
@micgro42 micgro42 deleted the fixDeprecatedActionNextCP branch January 9, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants