Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADR for using TypeScript without Decorators #83

Merged
merged 1 commit into from
Jul 16, 2020

Conversation

tzhelyazkova
Copy link
Contributor

Copy link
Member

@jakobw jakobw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, mostly added nitpicks and typo fixes!

docs/src/doc/dev/adr/0005-use-typescript.stories.mdx Outdated Show resolved Hide resolved
docs/src/doc/dev/adr/0005-use-typescript.stories.mdx Outdated Show resolved Hide resolved
docs/src/doc/dev/adr/0005-use-typescript.stories.mdx Outdated Show resolved Hide resolved
docs/src/doc/dev/adr/0005-use-typescript.stories.mdx Outdated Show resolved Hide resolved
docs/src/doc/dev/adr/0005-use-typescript.stories.mdx Outdated Show resolved Hide resolved
docs/src/doc/dev/adr/0005-use-typescript.stories.mdx Outdated Show resolved Hide resolved
docs/src/doc/dev/adr/0005-use-typescript.stories.mdx Outdated Show resolved Hide resolved
docs/src/doc/dev/adr/0005-use-typescript.stories.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@wiese wiese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smooth!

Copy link
Member

@jakobw jakobw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jakobw jakobw merged commit 7aacba6 into master Jul 16, 2020
@jakobw jakobw deleted the ts_no_decorators_adr branch July 16, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants