Skip to content

Commit

Permalink
build: bundle to avoid qwik optimizer issue
Browse files Browse the repository at this point in the history
See #23
  • Loading branch information
wmertens committed Oct 30, 2023
1 parent c11388f commit 8738946
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 15 deletions.
2 changes: 1 addition & 1 deletion src/css.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {keyframes, StyleRule} from '@vanilla-extract/css'
import {compile} from 'stylis'
import {type QwikStyledComponent} from './qwik-styled'
import {type QwikStyledComponent} from './qwik-styled.qwik'
import {type ClassNames} from './ve-style'

export const veClassRE = /^[a-zA-Z0-9_./]*[a-z0-9]{6}\d+$/
Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion src/qwik-styled.test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {describe, expect, it} from 'vitest'
import {isStyled, styled} from './qwik-styled'
import {isStyled, styled} from './qwik-styled.qwik'

describe('isStyled', () => {
it('should detect Styled functions', () => {
Expand Down
4 changes: 2 additions & 2 deletions src/ve-style.test.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import {FunctionComponent} from '@builder.io/qwik'
import type {FunctionComponent} from '@builder.io/qwik'
import {assertType, describe, expect, expectTypeOf, it} from 'vitest'
import {style, styled} from './ve-style'
import {setFileScope} from '@vanilla-extract/css/fileScope'
import {QwikStyledComponent} from './qwik-styled'
import {QwikStyledComponent} from './qwik-styled.qwik'
import {veClassRE, veMultiClassRE} from './css'

// Make VE happy about running in this file
Expand Down
2 changes: 1 addition & 1 deletion src/ve-style.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
QwikStyledComponent,
styled as realStyled,
Tags,
} from './qwik-styled'
} from './qwik-styled.qwik'

// Copy of Vanilla Extract's ClassNames type
export type ClassNames = string | Array<ClassNames>
Expand Down
14 changes: 4 additions & 10 deletions vite.config.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/// <reference types="vitest" />
import {defineConfig} from 'vite'
import {type LibraryFormats, defineConfig} from 'vite'
import {configDefaults} from 'vitest/config'
import {qwikVite} from '@builder.io/qwik/optimizer'
import pkg from './package.json'
Expand All @@ -14,12 +14,10 @@ export default defineConfig(() => {
build: {
target: 'es2020',
lib: {
entry: ['./src/index.ts', './src/qwik-styled.ts', './src/vite.ts'],
formats: ['es', 'cjs'],
entry: ['./src/index.ts', './src/qwik-styled.qwik.ts', './src/vite.ts'],
formats: ['es', 'cjs'] satisfies LibraryFormats[],
fileName: (format: string, entryName: string) =>
`${entryName}${entryName.includes('vite') ? '' : '.qwik'}.${
format === 'es' ? 'mjs' : 'cjs'
}`,
`${entryName}.${format === 'es' ? 'mjs' : 'cjs'}`,
},
rollupOptions: {
// externalize deps that shouldn't be bundled into the library
Expand All @@ -28,10 +26,6 @@ export default defineConfig(() => {
...excludeAll(dependencies),
...excludeAll(peerDependencies),
],
output: {
preserveModules: true,
preserveModulesRoot: 'src',
},
},
},
plugins: [qwikVite()],
Expand Down

0 comments on commit 8738946

Please sign in to comment.