Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow assert to be used in function names #4

Merged
merged 1 commit into from
Jun 1, 2017

Conversation

grahamc
Copy link

@grahamc grahamc commented May 26, 2017

Previously, the following would be incorrectly highlighted:

let 

    inherit (foo) assert-foo-bar;
in
    (assert-foo-bar foo-bar)

screen shot 2017-06-01 at 8 34 13 am

Previously, the following would be incorrectly highlighted:

    (assert-foo-bar foo-bar)

    inherit (foo) assert-foo-bar;
@grahamc
Copy link
Author

grahamc commented May 26, 2017

Now:
screen shot 2017-05-26 at 11 58 13 am

PS: thank you for having a license on the repo, letting me contribute :)

@grahamc
Copy link
Author

grahamc commented May 31, 2017

bump @wmertens?

@wmertens wmertens merged commit e5e1069 into wmertens:master Jun 1, 2017
@wmertens
Copy link
Owner

wmertens commented Jun 1, 2017

@grahamc sorry for the delay, this looks great, thanks!

@grahamc
Copy link
Author

grahamc commented Jun 1, 2017

Thank you! By the way, this contribution came on behalf of Tumblr.

@wmertens
Copy link
Owner

wmertens commented Jun 1, 2017

oh cool, I updated the release notes

@grahamc
Copy link
Author

grahamc commented Jun 1, 2017

Erm, sorry, but I just realized that the \w-' is a range and not three characters. It should probably be \w'-...

@wmertens
Copy link
Owner

wmertens commented Jun 1, 2017 via email

@grahamc
Copy link
Author

grahamc commented Jun 2, 2017

Repaired in #6 :) sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants