refactor: tidy up IsUndefined and extend tests

wmfs · Sep 15, 2022 · 00dea40 · 00dea40
1 parent f5efe84
commit 00dea40
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 10 deletions.
diff --git a/lib/operators/is-undefined.js b/lib/operators/is-undefined.js
@@ -1,15 +1,13 @@
 'use strict'
 
 module.exports = function isUndefinedOperator (inputValue, comparisonValue, candidateStateName, cache) {
-  let nextState
-  if (comparisonValue === true) {
-    if (inputValue === undefined) {
-      nextState = candidateStateName
-    }
-  } else if (comparisonValue === false) {
-    if (inputValue !== undefined) {
-      nextState = candidateStateName
-    }
+  const isUndefined = inputValue === undefined
+
+  if (isUndefined && comparisonValue === true) {
+    return candidateStateName
+  }
+
+  if (!isUndefined && comparisonValue !== true) {
+    return candidateStateName
   }
-  return nextState
 }
diff --git a/test/data-test-expr-tests.js b/test/data-test-expr-tests.js
@@ -77,6 +77,19 @@ const tests = {
     [0, true, 'DefaultState'],
     [false, true, 'DefaultState']
   ],
+  IsUndefined: [
+    [undefined, true, 'NextState'],
+    ['HELLO_WORLD', false, 'NextState'],
+    [null, false, 'NextState'],
+    [0, false, 'NextState'],
+    [false, false, 'NextState'],
+
+    [undefined, false, 'DefaultState'],
+    ['HELLO_WORLD', true, 'DefaultState'],
+    [null, true, 'DefaultState'],
+    [0, true, 'DefaultState'],
+    [false, true, 'DefaultState']
+  ],
   IsBoolean: [
     ['nope', false, 'NextState'],
     [true, true, 'NextState'],