fix: only apply map fly to value if id exists

wmfs · Jun 16, 2022 · ebde201 · ebde201
1 parent 5333d8d
commit ebde201
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/index.js b/lib/index.js
@@ -162,7 +162,9 @@ module.exports = async function extractDefaults (cardscript) {
         break
       case 'Map':
       case 'Input.Map': {
-        applyDefaultValue(defaultValues, null, apiLookupPath, cardListPath, element.id + 'MapFlyTo')
+        if (element.id) {
+          applyDefaultValue(defaultValues, null, apiLookupPath, cardListPath, element.id + 'MapFlyTo')
+        }
 
         const markers = element.markers ? [...element.markers] : []
         if (element.centre && element.centre.show) markers.push(element.centre)

diff --git a/test/extract-default-tests.js b/test/extract-default-tests.js
@@ -57,6 +57,10 @@ describe('Run some Cardscript default-extracting tests', function () {
         cardListNonEditable: [],
         toggle: false,
         tabSetTabSet: 'tab-0',
+        tabSetTabSetShowWhens: [
+          undefined,
+          undefined
+        ],
         choice: 'CHOICE_1',
         choiceMulti: ['CHOICE_1', 'CHOICE_2'],
         choiceWithTitle: 'CHOICE_1',