feat: user authorization check in tymly.startExecution

affects: tymly-test-helpers, tymly, tymly-diaries-plugin, addressbase-plus-blueprint,
addressbase-premium-blueprint, building-blueprint, care-quality-commission-blueprint,
demo-blueprint, food-hygiene-blueprint, heritage-blueprint, indices-multi-deprivation-blueprint,
ofsted-blueprint

Fixing tests so they don't fail for lack of authorization

lib/plugin/components/services/statebox/index.js

@@ -69,9 +69,9 @@ class StateboxService {
     } // if ...
 
     const [authOk, errExecDesc] = await this.authorisationCheck(stateMachineName, executionOptions, 'create')
-    return authOk ?
-      this.statebox.startExecution(input, stateMachineName, executionOptions) :
-      errExecDesc
+    return authOk
+      ? this.statebox.startExecution(input, stateMachineName, executionOptions)
+      : errExecDesc
   } // startExecution
 
   stopExecution (cause, error, executionName, executionOptions, callback) {
@@ -116,8 +116,9 @@ class StateboxService {
       action
     )
 
-    if (authorised)
+    if (authorised) {
       return [true]
+    } // if good ...
 
     return [
       false,

package.json

@@ -32,7 +32,8 @@
     "chai-subset": "1.6.0",
     "mocha": "5.2.0",
     "moment": "2.22.2",
-    "standard": "11.0.1"
+    "standard": "11.0.1",
+    "tymly-test-helpers": "0.0.1"
   },
   "scripts": {
     "lint": "standard",

test/generate-uuid-state-resource-spec.js

@@ -18,7 +18,7 @@ describe('Generate uuid state resource', function () {
         ],
         pluginPaths: [
           path.resolve(__dirname, './fixtures/plugins/cats-plugin'),
-          path.resolve(__dirname, './fixtures/plugins/say-yes-rbac-plugin')
+          path.resolve(__dirname, '../node_modules/tymly-test-helpers/plugins/allow-everything-rbac-plugin')
         ]
       },
       (err, tymlyServices) => {

test/memory-storage-tymly-spec.js

@@ -18,7 +18,7 @@ describe('Memory tymly-storage tests', function () {
           path.resolve(__dirname, './fixtures/blueprints/storage-blueprint')
         ],
         pluginPaths: [
-          path.resolve(__dirname, './fixtures/plugins/say-yes-rbac-plugin')
+          path.resolve(__dirname, '../node_modules/tymly-test-helpers/plugins/allow-everything-rbac-plugin')
         ]
       },
       function (err, tymlyServices) {

test/registry-state-tests.js

@@ -24,7 +24,7 @@ describe('registry key state resources', function () {
             path.resolve(__dirname, './fixtures/blueprints/registry-blueprint')
           ],
           pluginPaths: [
-            path.resolve(__dirname, './fixtures/plugins/say-yes-rbac-plugin')
+            path.resolve(__dirname, '../node_modules/tymly-test-helpers/plugins/allow-everything-rbac-plugin')
           ],
           config: {
             caches: {

test/run-function-state-resource-spec.js

@@ -20,7 +20,7 @@ describe('Test the run function state resource', function () {
         ],
         pluginPaths: [
           path.resolve(__dirname, './fixtures/plugins/cats-plugin'),
-          path.resolve(__dirname, './fixtures/plugins/say-yes-rbac-plugin')
+          path.resolve(__dirname, '../node_modules/tymly-test-helpers/plugins/allow-everything-rbac-plugin')
         ]
       },
       (err, tymlyServices) => {

test/run-state-machine-resource-tests.js

@@ -29,7 +29,7 @@ describe('run-state-machine state resource test', function () {
           pluginPaths: [
             path.resolve(__dirname, './fixtures/plugins/cats-plugin'),
             path.resolve(__dirname, './fixtures/plugins/heartbeat-plugin'),
-            path.resolve(__dirname, './fixtures/plugins/say-yes-rbac-plugin')
+            path.resolve(__dirname, '../node_modules/tymly-test-helpers/plugins/allow-everything-rbac-plugin')
           ]
         },
         function (err, tymlyServices) {
@@ -113,7 +113,7 @@ describe('run-state-machine state resource test', function () {
             path.resolve(__dirname, './fixtures/blueprints/cats-wrapper-blueprint')
           ],
           pluginPaths: [
-            path.resolve(__dirname, './fixtures/plugins/say-yes-rbac-plugin')
+            path.resolve(__dirname, '../node_modules/tymly-test-helpers/plugins/allow-everything-rbac-plugin')
           ]
         },
         function (err, tymlyServices) {
@@ -173,7 +173,7 @@ describe('run-state-machine state resource test', function () {
           ],
           pluginPaths: [
             path.resolve(__dirname, './fixtures/plugins/justfail-plugin'),
-            path.resolve(__dirname, './fixtures/plugins/say-yes-rbac-plugin')
+            path.resolve(__dirname, '../node_modules/tymly-test-helpers/plugins/allow-everything-rbac-plugin')
           ]
         },
         function (err, tymlyServices) {

test/statebox-tests.js

@@ -20,7 +20,7 @@ describe('Simple Tymly test', function () {
 
         pluginPaths: [
           path.resolve(__dirname, './fixtures/plugins/cats-plugin'),
-          path.resolve(__dirname, './fixtures/plugins/say-yes-rbac-plugin')
+          path.resolve(__dirname, '../node_modules/tymly-test-helpers/plugins/allow-everything-rbac-plugin')
         ]
       },
       function (err, tymlyServices) {

test/timestamp-state-resource-tests.js

@@ -23,7 +23,7 @@ describe('timestamp state resources', function () {
           path.resolve(__dirname, './fixtures/blueprints/timestamp-blueprint')
         ],
         pluginPaths: [
-          path.resolve(__dirname, './fixtures/plugins/say-yes-rbac-plugin')
+          path.resolve(__dirname, '../node_modules/tymly-test-helpers/plugins/allow-everything-rbac-plugin')
         ]
       },
       function (err, tymlyServices) {