Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlight colors are becoming too dark #323

Closed
montoner0 opened this issue Apr 11, 2024 · 8 comments
Closed

Syntax highlight colors are becoming too dark #323

montoner0 opened this issue Apr 11, 2024 · 8 comments
Assignees
Labels
bug Highlight Syntax highlight

Comments

@montoner0
Copy link

For some reason some bright colors I've configured are becoming much darker after VS restart (not every time, can't catch the exact moment). I wonder why Codist would ever tamper with the user configured colors... Also noticed that they are also darken within an exported theme...

@montoner0
Copy link
Author

Even weirder thing: colors in preview and in a picker don't match
image

@wmjordan
Copy link
Owner

Please upload your VS theme and Codist configuration file here so I can test it.

@montoner0
Copy link
Author

I use the standard Blue theme with non-standard colors. Please see the attached files.
Exported-2024-04-12_colors.vssettings.zip
Codist.json.zip

@wmjordan
Copy link
Owner

I analyzed the VS settings and found the cause of your issue.
Codist automatically adjusts the brightness of the syntax theme to the VS theme.
However, the algorithm is not stable when the editor is dark but other text windows are bright, or vise versa.
I currently can not think of a way to perfectly deal with situations like this.
I will let you know if there is a new beta version which address this issue.

@wmjordan wmjordan added bug Highlight Syntax highlight labels Apr 28, 2024
@wmjordan wmjordan self-assigned this Apr 28, 2024
@montoner0
Copy link
Author

As a quick solution you could add an option to disable the auto-adjusting.

@wmjordan
Copy link
Owner

Please try beta 9822.

@montoner0
Copy link
Author

I was using the beta for several days and so far it seems good. However I've seen other issues (not related to highlighting) though haven't found a way to reproduce, they seem random so far...

@wmjordan
Copy link
Owner

Well.
If you encounter that problem once again, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Highlight Syntax highlight
Projects
None yet
Development

No branches or pull requests

2 participants