Added data-contents-only support, based on kelvinhammond's attempt to do the same. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing due to some conflicting metadata. Reopened as a separate PR. |
|
You could merge either this or PR 8, but by the time you read this I will probably have re-closed this PR. I reopened it because I realized that by closing it I froze the history displayed by GitHub, and I have since updated the history on my branch. Given that you hadn't merged yet I thought I would correct my mistake. Anyway, in hindsight I realize that closing the PR and opening a new one was unnecessary -- I could've done the same with the original PR. My apologies for potentially spamming your email with a duplicate PR and some extra comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one passes all the unit tests, including new unit tests for the feature.