Fix Marshaling of Dialogue #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linouxis9
force-pushed
the
master
branch
2 times, most recently
from
6ac404f
to
a549da7
Compare
|
It seems there is an issue with your golangci-lint pipeline: https://github.com/wmnsk/go-tcap/actions/runs/8440015877/job/23120006589?pr=17#step:3:81 The golangci-lint version used does not seem to work with the golang toolchain used. You are probably hitting a bug similar to golangci/golangci-lint#4273. golangci-lint's version to be used in the pipeline should be updated. |
wmnsk
reviewed
Mar 29, 2024
|
Thanks a lot for your comments and suggestions! |
|
Suggestions applied, and test case (DialoguePDU containing a dummy UserInformation) added. |
wmnsk
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marshaling of Dialogue was incorrect.
Unmarshaling was filling both SingleAsn1Type and DialoguePDU, so marshaling back was writting both which is incorrect.
Issues found with unit tests were fixed, thanks :-)
Next PR is to support marshaling of nested/recursive IEs!