-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New BUFR sequences for encoding IKFS2 products #10
Comments
Hi @erget, many thanks for the BUFR template, ECMWF is looking forward to receiving the data.
|
@marijanacrepulja thanks for pointing out the issue with the duplicated bits - it was a table copying error. In fact I'd set the table wider than needed. We do need a reserved bit at the end so that the entry can be set to MISSING if necessary - if we don't reserve the bit at the end, there's no differentiation between all flags being set and no data being reported. Concerning the |
@erget thanks for the request for a new descriptor. As for flag table I meant to write that should start with 1 and finished with All 10 Missing value For example I copied flag table for 0 02 022 Satellite data-processing technique used |
@marijanacrepulja OK I see what you mean, I've updated the formulation of the table. |
@erget Just to avoid any confusion, in the detailed proposals, can I understand:
|
@jitsukoh yes, that's correct - not sure how that slipped past me. I've updated the text accordingly. |
Input from @SibylleK:
|
@SibylleK I have implemented your requests in the proposal above. |
New BUFR sequences for encoding IKFS2 products #10 Add the following elements to BUFR Table B/07
New BUFR sequences for encoding IKFS2 products #10 Add the following elements to BUFR Table B/40
New BUFR sequences for encoding IKFS2 products #10 Add flag table 0-40-074 with the following contents:
New BUFR sequences for encoding IKFS2 products #10 Add the following sequence 3 40 018 “Infrared Fourier Spectrometer - 2 (IKFS-2) spectra” to BUFR Table D/40:
@erget Hi, Daniel, I have already created the branch for this issue. Could you please check it and the tables? Thanks. |
@chenxiaoxia2019 thanks for this. I wasn't sure where to put my comments regarding this so I've duplicated them in the PR and in this issue. Content reviewI've reviewed the CSVs only, although I marked the text and XML files as reviewed in order to make it easier to step through the PR. I don't think There are also some issues in Proposed process improvementI think we should clarify the review process for instances like this and propose the following workflow:
|
I've updated the proposal to use the new descriptor numbers provided by the secretariat. The changes I requested in my previous comment are still outstanding on this issue's branch, but in the assumption that they will be resolved as described in the proposal, I've had sample data created. Please let me know when you've downloaded it so that I can free the storage; this is not a permalink. |
@erget Dimensions for Radiance in channel in the HDF5 file is AtmSpRadiances (3541,15,2701), meaning that we have 2701 channels. In the proposed template we have |
@marijanacrepulja you're right, while producing the sample data we made some changes to that part of the sequence and I forgot to note that in the proposal. I've now updated the proposal - it matches the sample data, which you should not have been able to read using the definitions noted above before. @chenxiaoxia2019 I'm not sure about the process for creating new branches that match proposals - I think it might be cleanest for this to be done by the secretariat, i.e. you, but theoretically I see that proposers can implement changes to the branches as well. It gets complex when potentially hitting the same numbers and I'm also not familiar with which files need to be edited and which ones get autogenerated... Could you please implement the necessary changes or let me know what the desired procedure is? |
Hi, Daniel, @erget I have created all the branches for all the issues respecitively. Take issue 10 for an example, branch "issue-10" is created for it, with the changes made in BUFRCREX_TableB_en_40.csv and BUFR_TableD_en_40.csv. The description for these two files is "update issue 10". AND, you can also use the COMPARE https://github.com/wmo-im/BUFR4/compare/issue-10 to see any changes.
|
Hi @chenxiaoxia2019 thanks for the explanation. Some points below.
Thanks, I'm able to find that based on the fact that you added the "Branch" section to the issue description at the top. It would be really nice to have a CONTRIBUTING.md file in the repository that describes what you're saying, because it's currently not clear IMHO that the CSV files are the ones that should be reviewed.
OK. I guess stated more clearly, I've found issues in the branch devoted to this issue that I have annotated in a pull request so that you can see exactly what lines I'm referring to and requested that you implement changes accordingly. Probably you can get by with double-checking the changes in the branch with the current state of the proposal at the top of this issue - I would be happy to cross-check that for you afterwards. While I think this is a good way to do things, so that in the end the secretariat is the one implementing changes to the tables, it would also be possible to just make the changes in the branch directly so that we don't add another layer of turnaround. I'm working under the assumption that all table changes should be done by the secretariat and hope that this doesn't unduly burden you. In sum though it's important to note that the branch currently contains errors, and that there is a contradiction in numbers between this and another proposal that will need to be resolved. |
@erget I have been able to decode the data. W_XX-EUMETSAT-Darmstadt,SURFACE+SATELLITE,M02+OCN_C_EUMP_20200611071500_30735_2.0_VV.bin_decoded.gz |
@marijanacrepulja thanks for looking. @chenxiaoxia2019 would you be willing to update the branch to match the proposal as described at the top of the issue? |
@erget Hi, Daniel, branch has already been updated as proposed, changing from 007XXX to 007072 in both table B and table D. |
@chenxiaoxia2019 I'm actually referring to the changes needed as per #10 (comment) and #10 (comment). You can see them line-for-line as described in #25. In summary changes are needed to the branch because beyond replacing 007XXX because:
Can you have a look please? Feel free to write to me if you need my help. |
@chenxiaoxia2019 I've corrected the issues on the associated branch, everything should be fine now. |
SUMMARY: Add entry to Table B Class 40, add Flag Table 0 40 074, add entry to Table B Class 07 and add entries to Table D Category 40. |
@erget We are preparing the manual for publication and need some clarification. What does "on as a rule" mean?
Some suggestions:
|
@amilan17 (2) is right. |
Branch
https://github.com/wmo-im/BUFR4/tree/issue-10
Summary and purpose
This document proposes new BUFR sequences and quality flags in order to encode radiances observed using the IKFS-2 instrument on board the Meteor-M N2 satellites.
Action proposed
The meeting is requested to approve the contents for inclusion within the next update to the WMO Manual on Codes.
Discussions
The Infrared Fourier Spectrometer - 2 (IKFS-2) is a passive cross-nadir infrared sounder for temperature and humidity sounding. It can also be used to observe the ozone profile and total column greenhouse gases. The IKFS-2 flies on RosHydroMet’s Meteor-M N2 satellites. This series consists of seven satellites, with an expected temporal coverage from 2014 to 2028.
It is proposed to add three quality elements and a sequence to the Manual on Codes. These are intended for use in encoding spectral observations from the IKFS-2 instrument, along with a selection of quality data.
A previous version of this proposal was sent to CGMS TFSDC on 11 Dec 2019 and received no negative feedback. Since that version the sequence was refined based on inputs received from ECMWF.
Detailed proposal
Add the following elements to BUFR Table B/07 and B/40:
Add flag table 0-40-074 with the following contents:
Add the following sequence 3 40 018 “Infrared Fourier Spectrometer - 2 (IKFS-2) spectra” to BUFR Table D/40:
The text was updated successfully, but these errors were encountered: